Skip to content

Conversation

@HeleneAmouzou
Copy link
Contributor

@HeleneAmouzou HeleneAmouzou commented Oct 23, 2025

What does this PR do?

  • Adds Kubernetes dashboard to index.html,
  • Declines cc-addon-header and cc-addon-info for Kubernetes product.

How to review?

  • Check the commits,
  • Check the code,
  • Play with demo-smart.

@github-actions
Copy link
Contributor

🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/dashboard-addons/kube/index.html.

This preview will be deleted once this PR is closed.

@florian-sanders-cc florian-sanders-cc changed the title feat(cc-addon-header.smart-kubernetes): init feat(cc-addon-*.smart-kubernetes): init Oct 27, 2025
Copy link
Member

@roberttran-cc roberttran-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice adaptations, good job! A few non-blocking feedback for me (aka the janitor). 🧹

Copy link
Contributor

@pdesoyres-cc pdesoyres-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done Hélène. I left few questions and comments

productStatus?: string;
deploymentStatus?: DeploymentStatus;
configLink?: string;
configLink?: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: isn't it a breaking change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically yes, but since we have only created this prop for Kubernetes, we though we could leave it as it is, but if others think we should make it a proper breaking change, we will do so !

@HeleneAmouzou HeleneAmouzou force-pushed the dashboard-addons/kube branch 2 times, most recently from eb031ff to b64bcb3 Compare October 28, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants