-
Couldn't load subscription status.
- Fork 23
feat(cc-addon-*.smart-kubernetes): init #1588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/dashboard-addons/kube/index.html. This preview will be deleted once this PR is closed. |
478ba66 to
0d123d4
Compare
0d123d4 to
457e417
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice adaptations, good job! A few non-blocking feedback for me (aka the janitor). 🧹
src/components/cc-addon-header/cc-addon-header.smart-kubernetes.js
Outdated
Show resolved
Hide resolved
src/components/cc-addon-header/cc-addon-header.smart-kubernetes.js
Outdated
Show resolved
Hide resolved
src/components/cc-addon-header/cc-addon-header.smart-kubernetes.md
Outdated
Show resolved
Hide resolved
src/components/cc-addon-header/cc-addon-header.smart-kubernetes.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done Hélène. I left few questions and comments
src/components/cc-addon-header/cc-addon-header.smart-kubernetes.js
Outdated
Show resolved
Hide resolved
| productStatus?: string; | ||
| deploymentStatus?: DeploymentStatus; | ||
| configLink?: string; | ||
| configLink?: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: isn't it a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically yes, but since we have only created this prop for Kubernetes, we though we could leave it as it is, but if others think we should make it a proper breaking change, we will do so !
eb031ff to
b64bcb3
Compare
src/components/cc-addon-header/cc-addon-header.smart-kubernetes.js
Outdated
Show resolved
Hide resolved
… messages Avoid mentioning the `add-on` term
Avoid mentioning the `add-on` term
Avoid mentioning the `add-on` term in translations
b64bcb3 to
d378900
Compare
d378900 to
530a10c
Compare
What does this PR do?
index.html,cc-addon-headerandcc-addon-infofor Kubernetes product.How to review?
demo-smart.